Skip to content

feat(vpc): add support for ResourceIdentity #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(vpc): add support for ResourceIdentity #3143

wants to merge 3 commits into from

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 5, 2025 •
edited
Loading

Import can be done by identity now:

import {
  to       = scaleway_vpc.main
  identity = {
    id     = "11111111-1111-1111-1111-111111111111"
    region = "fr-par"
  }
}


resource "scaleway_vpc" "main" {}

@yfodil yfodil self-assigned this Jun 5, 2025
@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jun 5, 2025
jremy42
jremy42 reviewed Jun 6, 2025
View reviewed changes
internal/services/vpc/vpc.go
@@ -21,7 +23,56 @@ func ResourceVPC() *schema.Resource {
UpdateContext: ResourceVPCUpdate,
DeleteContext: ResourceVPCDelete,
Importer: &schema.ResourceImporter{
StateContext: schema.ImportStatePassthroughContext,
StateContext: func(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a way to make a global function, since it'll basically be the same across all resources, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jremy42 jremy42 jremy42 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@yfodil yfodil

Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfodil @jremy42